Forums / 8051 Discussion Forum / Reviving the legendary Nokia3310 LCD - Rickey's World of Microcontrollers & Microprocessors

Discussion in "8051 Discussion Forum" started by SmandyS Sep 13, 2012.

SmandyS

[ Member ]

Sat Sep 15 2012, 09:34 pm

#11

i have changed the background...here is -
trying to show analog thermometer, working but buggy at the moment...

other portions not used yet

as you can see, am planning to implement RTC in near future...
a large portion empty.....

i shall deal with it.....

[ Edited Sat Sep 15 2012, 10:37 pm ]

SmandyS

[ Member ]

Sat Sep 15 2012, 10:38 pm

#12

successfully updated my big size custom fonts -

[ Edited Sat Sep 15 2012, 11:51 pm ]

SmandyS

[ Member ]

Sat Sep 15 2012, 11:48 pm

#13

ok...now i have decided my final layout---

[ Edited Mon Sep 17 2012, 04:06 am ]

SmandyS

[ Member ]

Mon Sep 17 2012, 01:54 am

#14

RTC1307 interface ok....

Engineero like this.

ajay_bhargav

Site Owner

Mon Sep 17 2012, 05:18 pm

#15

wow this look marvellous. You really surprised me

SmandyS

[ Member ]

Wed Sep 19 2012, 01:46 am

#16

didn't get time to update my code..

i shall try today to debug the remaining part..

[ Edited Wed Sep 19 2012, 02:59 pm ]

SmandyS

[ Member ]

Thu Sep 20 2012, 02:25 am

#17

@ajay..

i need you help..

i ave sent you the code and proteus files...
please look inot and advise for setting the time..

ajay_bhargav

Site Owner

Thu Sep 20 2012, 03:00 am

#18

advice for setting time? can you explain a bit more?

SmandyS

[ Member ]

Thu Sep 20 2012, 11:01 am

#19

i have interfaced the buttons to set time on RTC...

have used an external interrupt to enable settings mode....
but when it enters the settings mode..... and when i press the button, it starts changing the hours fastly

can you please look into the code which i have sent you..

FYI - i am using RTC for clock purpose here, the time being displayed on Nokia LCD, i want to chenge that time through buttons..

[ Edited Thu Sep 20 2012, 11:03 am ]

ajay_bhargav

Site Owner

Fri Sep 21 2012, 12:36 am

#20

It was a bit difficult to understand your code logic I mean the way you're written your code. So here is the thought:
1. Make things simple
2. If you enter in RTC adjustment loop stay there till you finish adjusting time.
3. You're using 8051 which mean your port pins are directly addressable and can be checked individually. stop checking this way..

if(P1_State == 0xD0)

How would I know 0xD0 means, or 0xB0 or 0x70.... and USE proper names for all the pins.. e.g. if your set time key is connected to Port pin 1.1 then define it properly. This makes code more readable.

#define SET_KEY P1_1
//use it later as
if (SET_KEY) {
    //do something
}

To Be true I do not understand your set time logic. coz true or false your switch case will always execute thats the reason as soon as you press settime key your hours start incrementing. As I already mentioned in my point #1 KEEP THINGS SIMPLE

when you are in set time just set time forget everything else. One way to do this is write a small program, a separate one just for setting time. where you only read keys status and do stuff accordingly. Once you are done with it, move that code to actual working part.