Discussion in "Project Doubts" started by    sankalp_s    Nov 29, 2014.
Wed Feb 17 2016, 06:39 PM
#81


It is just a case adding loops to the code,
I'm sure you will work it out.



Thank you so much sir, for great help and great support.
sure sir i'll try for that.
Fri Jan 13 2017, 06:52 PM
#82
Hi phill sir..
testButton1:
               	
				 mov A,BIT_VAR ;debug
				 mov P1,A
				 
              
		        jb progBit1,testButton2	    
				orl P1,#0x20  ;debug
                call program0  ;Run this segment if button pressed
                sjmp testButton1  ;done

testButton2:

              
				jb progBit2,default
				orl P1,#0x40  ;debug
                call program2  ;Run this segment if button pressed
                sjmp testButton1
default:  
                orl P1,#0x80  ;debug
                call program1  ;Run this segment if no buttons pressed
                sjmp testButton1


Above mention code is not working.. only default program executes..whatever conditions of buttons, they are pressed or not it makes no any changes.(This function works fine with old code but not working with this table method)

And sir please also explain me how can add 24 bit display.. i'm unable to increase from 16 to 24 bcoz of DPTR limitations.
Thanks sir.

I've attached the whole code..
Attachment


[ Edited Sun Jan 15 2017, 08:00 PM ]
Sat Jan 14 2017, 11:54 PM
#83
There is a fault in your Proteus design.
If you look carefully (magnify) you will see the ground point is actually a junction dot.
Add a new ground point from the 'Terminal mode ' menu.
The buttons will work now.
Buttons should show as red and blue, and change when pressed,
If not, post your Proteus design and the code you are using.

Sun Jan 15 2017, 07:55 PM
#84


There is a fault in your Proteus design.
If you look carefully (magnify) you will see the ground point is actually a junction dot.
Add a new ground point from the 'Terminal mode ' menu.
The buttons will work now.
Buttons should show as red and blue, and change when pressed,
If not, post your Proteus design and the code you are using.


ExperimenterUK


Hello sir, i'm using the code in development board where every thing is ok..
i'm attaching both non working and working code here.
please look both once. There is no changes in asm files of both codes but include files are different.. in non working code *.inc file is written in table method and other which is working, written in old method which is DUMPED by us.

i've tried both.



[ Edited Sun Jan 15 2017, 07:59 PM ]
Wed Jan 18 2017, 12:56 AM
#85
Here is a new version that works on the circuit you posted.


"And sir please also explain me how can add 24 bit display..
i'm unable to increase from 16 to 24 bcoz of DPTR limitations.
"
The DPTR does not impose any limitation on the number of LEDs.
If you look at "displayloop:" you will see that it moves one byte at a time from the table
to a port.
Just move three bytes (24 bits) instead of 2 (16 bits) in every call to "displayloop:"




 sankalp_s like this.
Wed Jan 18 2017, 07:28 PM
#86
Thank you so much dear sir. I think problem was memory allocation..



The DPTR does not impose any limitation on the number of LEDs.
If you look at "displayloop:" you will see that it moves one byte at a time from the table
to a port.
Just move three bytes (24 bits) instead of 2 (16 bits) in every call to "displayloop:"


ExperimenterUK



I'm doing like dis:





dw 000000000000000000000000b
       dw 100000000000000000000000b  
       dw 110000000000000000000000b  
	   dw 111000000000000000000000b
	   dw 111100000000000000000000b  
	   dw 111110000000000000000000b  
	   dw 111111000000000000000000b
........................
.............................


displayloop:
	 
     mov A,table_count  ;copy the number of lines to display
     mov tmp_table_count,A
	 
d_loop:
     mov A,#0
     movc A,@A+dptr ;get the top 6 bits
	call mirrorbyte; ;reverse pattern to suit hardware
	 mov P1,A      ;display pattern
	 inc dptr  
	   
	 mov A,#0
     movc A,@A+dptr ;get the low 6 bits
	 call mirrorbyte
	 mov P0,A
	 inc dptr

	  mov A,#0
     movc A,@A+dptr ;get the low 6 bits
	 call mirrorbyte
	 mov P2,A
	 inc dptr
	
	 
	 //call delay2       ;pause
	 call delay_keycheck    ;pause and checkbuttons.. can change return address, be careful
	 djnz tmp_table_count,d_loop	;next line of table
     ret	 

It gives result like zig zag and blinking (not according to given instructions.) m i doing wrong sir?
Wed Jan 18 2017, 09:28 PM
#87
This is your error
"dw 000000000000000000000000b"

dw stands for define word, meaning 16 bits of storage.
The assembler only stored 16 bits of the 24 bits you expected.

In the attached file I use.
dw 0000000000000000b
db 00000001b

This stores 16 bits then 8 bits per entry.

Don't forget, I used P1 for debugging, you will need to turn that off.




 sankalp_s like this.
Thu Jan 19 2017, 05:52 PM
#88
Thank you sir.. understood the logic..


But reverse loop is not working for 24 bits only port 2 and port 2 are functioning.
I'm doing this:

	reverse24displayloop:
     mov A,table_count  ;copy the number of lines to display
     mov tmp_table_count,A 
	 rl A ;2 bytes per line
inc_dptr24:	 
	 dec A
	 jz noinc_dptr
	 inc dptr
	 jmp inc_dptr24
noinc_dptr24:	 
r_loop24:	 

     mov A,#0
     movc A,@A+dptr ;get the top 6 bits
	 call mirrorbyte; ;reverse pattern to suit hardware
	 mov P2,A      ;display pattern
	 ;8051 has no "dec dptr" instruction, so do it the hard way.
	 dec DPL
	 MOV R7,DPL
	 cjne R7,#255,rdl1_24
	 dec dph
rdl1_24:	 
	
	 mov A,#0
     movc A,@A+dptr ;get the low 6 bits
	 call mirrorbyte
	 mov P0,A
	 dec DPL
	 MOV R7,DPL
	 cjne R7,#255,rdl2_24
	 dec dph
 rdl2_24:
	 mov A,#0
     movc A,@A+dptr ;get the low 6 bits
	 call mirrorbyte
	 mov P0,A
	 dec DPL
	 MOV R7,DPL
	 cjne R7,#255,rdl3_24
	 dec dph

rdl3_24:

   

	 call delay_keycheck    ;pause and checkbuttons.. can change return address, be careful
	 djnz tmp_table_count,r_loop
     ret

Fri Jan 20 2017, 12:31 AM
#89
The original reverse24displayloop:
was a bit messy.
Try this version.




[ Edited Fri Jan 20 2017, 09:44 PM ]
 sankalp_sajay_bhargav like this.
Fri Jan 20 2017, 04:40 PM
#90
Thank you so much sir for your great response..

Get Social

Information

Powered by e107 Forum System

Conversation

Tue Jan 22 2019, 06:51 AM
chnlovelyo
writing
ExperimenterUK
Mon Jan 07 2019, 03:31 AM
@REVOCATUS please post in the AVR forum
Mon Dec 24 2018, 09:25 AM
REVOCATUS MATEMU
sorry I mean referee boards for player substitution
Mon Dec 24 2018, 09:24 AM
REVOCATUS MATEMU
hi am.looking how to build referee by using Atmega 328 and its codes
Sat Dec 15 2018, 01:45 PM
Arslan ayoub
Hii ,, can I get the simulation of numeric keypad lock on proteus
ExperimenterUK
Mon Dec 03 2018, 05:17 PM
Please post questions in the forum. The chat box is for chat
Mon Dec 03 2018, 06:43 AM
help!me!
help! I don't understand busy flag!
Sun Dec 02 2018, 08:01 PM
ile
hello
Mon Nov 12 2018, 05:58 AM
Pavan_user
i have seen your replica of I2C programming using AT89C51 but i am unable to understand the "ack_bit" variable usage ...looks like it is always 1...can you elaborate how acknowledgment is working....
bgk3678
Tue Nov 06 2018, 02:36 PM
kindly any one give solution for my problem

Downloads

Comments

garfield0929
Sun Jan 20 2019, 12:48 AM
servprov
Thu Jan 17 2019, 06:44 AM
marcomilazzo
Wed Jan 16 2019, 04:21 PM
sandhyashree
Wed Jan 16 2019, 04:04 PM
SONACHAI1234
Sun Jan 06 2019, 08:14 AM
manan.gulyaani
Tue Jan 01 2019, 07:58 AM
etech
Sun Dec 30 2018, 07:44 PM
NeilC
Sun Dec 23 2018, 07:39 PM

Online

Guests: 71, Members: 0 ...

most ever online: 182184
(Members: , Guests: 182184) on 06 Aug 2010: 05:37 AM

Members: 38039
Newest member: garfield0929
Forum Activity
ExperimenterUK Avatar
Posted By ExperimenterUK
Sun Jan 06 2019, 10:37 PM
Which 8051 chip are you using ?
SONACHAI1234 Avatar
Posted By SONACHAI1234
Sun Jan 06 2019, 08:21 AM
Hi,By mistakenly i burn rx program in my 8051 micr...
ExperimenterUK Avatar
Posted By ExperimenterUK
Wed Dec 19 2018, 06:27 PM
Nobody knows?sifirsekizThe problem is that you are...
sifirsekiz Avatar
Posted By sifirsekiz
Wed Dec 19 2018, 12:15 PM
sifirsekiz Avatar
Posted By sifirsekiz
Sun Dec 16 2018, 11:13 PM
Guys pleaseeeee :((
sifirsekiz Avatar
Posted By sifirsekiz
Sat Dec 15 2018, 07:09 PM
HiThe pulse-sensor-amped has an analogue output.Th...
ExperimenterUK Avatar
Posted By ExperimenterUK
Sat Dec 15 2018, 07:01 PM
HiThe pulse-sensor-amped has an analogue output.Th...
sifirsekiz Avatar
Posted By sifirsekiz
Sat Dec 15 2018, 09:02 AM
and ı have pulse sensor one out but anolog use 805...
sifirsekiz Avatar
Posted By sifirsekiz
Sat Dec 15 2018, 08:56 AM
HiMembers can supply code and diagrams if they wan...
ExperimenterUK Avatar
Posted By ExperimenterUK
Fri Dec 14 2018, 11:54 PM
HiMembers can supply code and diagrams if they wan...